More robust sample testing python #300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyero-aws
changed the title
pelaezryan
reviewed
Jul 3, 2025
| }' \ | ||
| --return-values NONE | ||
|
|
||
| # Delete all tables |
There was a problem hiding this comment.
Can we delete commented out code?
| if aws kinesis create-stream --stream-name $STREAM_NAME --shard-count 1; then | ||
| break | ||
| else | ||
| echo "Stream creation failed, attempt $i/10. Waiting $((i * 3)) seconds..." |
There was a problem hiding this comment.
Is there a reason we scale like this for sleeping?
There was a problem hiding this comment.
A simple retry wasn't thorough enough but an exponential backoff was a bit overkill, I found that linear backoff was a good in-between point
| #!/bin/bash | ||
| set -e | ||
|
|
||
| LEASE_EXISTS=$(aws dynamodb scan --table-name $APP_NAME --select "COUNT" --query "Count" --output text || echo "0") |
| set -e | ||
|
|
||
| LEASE_EXISTS=$(aws dynamodb scan --table-name $APP_NAME --select "COUNT" --query "Count" --output text || echo "0") | ||
| CHECKPOINT_EXISTS=$(aws dynamodb scan --table-name $APP_NAME --select "COUNT" --filter-expression "attribute_exists(checkpoint) AND checkpoint <> :trim_horizon" --expression-attribute-values '{":trim_horizon": {"S": "TRIM_HORIZON"}}' --query "Count" --output text || echo "0") |
There was a problem hiding this comment.
nit: NUM_CHECKPOINTS_FOUND
.github/workflows/python.yml
Outdated
| PR_URL: ${{github.event.pull_request.html_url}} | ||
| GH_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
|
|
||
| # # update permissions to 'contents: write' when enabled |
There was a problem hiding this comment.
Lets remove unused code if its not planned to be in use.
| APP_NAME: ${{ env.APP_NAME }} | ||
|
|
||
| # Clean up all existing Streams and DDB tables | ||
| - name: Clean up Kinesis Stream and DynamoDB table |
There was a problem hiding this comment.
Is there a scenario where this may not run or the job fails out before this point?
There was a problem hiding this comment.
No, even if the job fails out before this point the if:always() makes sure this step always runs
pelaezryan
previously approved these changes
Jul 3, 2025
pelaezryan
requested changes
Jul 11, 2025
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # Manipulate sample.properties file that the KCL application pulls properties from (ex: streamName, applicationName) |
There was a problem hiding this comment.
# Manipulate sample.properties file that the KCL application pulls properties from (ex: streamName, applicationName)
sed -i "" "s/kclpysample/$STREAM_NAME/g" samples/sample.properties
sed -i "" "s/PythonKCLSample/$APP_NAME/g" samples/sample.properties
sed -i "" 's/us-east-5/us-east-1/g' samples/sample.properties
# Depending on the OS, different properties need to be changed
if [[ "$RUNNER_OS" == "macOS" ]]; then
grep -v "idleTimeBetweenReadsInMillis" samples/sample.properties > samples/temp.properties
echo "idleTimeBetweenReadsInMillis = 250" >> samples/temp.properties
mv samples/temp.properties samples/sample.properties
elif [[ "$RUNNER_OS" == "Linux" || "$RUNNER_OS" == "Windows" ]]; then
sed -i "/idleTimeBetweenReadsInMillis/c\idleTimeBetweenReadsInMillis = 250" samples/sample.properties
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added more robust checks for kcl functionality.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.